Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IconExtension for WinUI #493

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

tajbender
Copy link
Contributor

@tajbender tajbender commented Oct 17, 2024

Edit stub of IconExtension

@tajbender tajbender changed the title Add IconExtension Add IconExtension for WinUI Oct 17, 2024
Copy link
Contributor Author

@tajbender tajbender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial commit. Builds fine.

e./: @dahall This is a Draft currently ⛑️

@tajbender tajbender marked this pull request as draft November 2, 2024 00:31
@tajbender
Copy link
Contributor Author

tajbender commented Nov 27, 2024

@dahall: May I have an answer or your opinion:

For IconExtractor - Thx again 👍 - what lifetime would be the best?

  • Should I use an own Instance of IconExtractor for every single folder / enumeration?
  • Or should I use one Instance per lifetime, let's say of the Control - or even the App?

e./ regarding the lifetime I need for the Control itself:

  • I create a single BitmapSource from each Icon Image I gather through IconExtractor (so, I use an own Cache for the Images after they have been extracted from the Shell32 Icon)
  • I'll implement a small cache for those. I thought about using the original SysIconIndex as Indexer for this
  • I'll implement an optional ViewMode, that only uses StockItems. Another one without ThumbNails
  • For Details View, I'll use a Vanara.Windows.Shell.ShellDataTable

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant