Handle stalled threaded queued-run launches without resetting workers#33678
Draft
zoltanmaric wants to merge 1 commit intodagster-io:masterfrom
Draft
Handle stalled threaded queued-run launches without resetting workers#33678zoltanmaric wants to merge 1 commit intodagster-io:masterfrom
zoltanmaric wants to merge 1 commit intodagster-io:masterfrom
Conversation
Track in-flight launch futures across iterations and stop waiting after a bounded no-progress window so the queued run daemon can keep heartbeating and continue dequeuing later runs without tearing down its worker pool. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
make ruffpytest python_modules/dagster/dagster_tests/daemon_tests/test_queued_run_coordinator_daemon.py -qpyright python_modules/dagster/dagster/_daemon/run_coordinator/queued_run_coordinator_daemon.py python_modules/dagster/dagster_tests/daemon_tests/test_queued_run_coordinator_daemon.pyMade with Cursor