deploy an arm64 github action image as well as an amd64 image#233
Draft
deploy an arm64 github action image as well as an amd64 image#233
Conversation
|
Your pull request is automatically being deployed to Dagster Cloud.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
gibsondan
force-pushed
the
addarm64image
branch
2 times, most recently
from
11ed1ec to
9f18b87
Compare
gibsondan
commented
Jul 16, 2025
| RUN /opt/python/cp312-cp312/bin/python -m pip install dagster-cloud-cli | ||
| FROM quay.io/pypa/manylinux_2_28_${TARGET_ARCH}:latest | ||
|
|
||
| # Create virtual environment using PEX |
Member
Author
There was a problem hiding this comment.
i just took the PEX out here since it was having build issues on arm64 - I don't really understand why we needed that if we are already installing the dagster-cloud-cli below
gibsondan
commented
Jul 16, 2025
Member
Author
gibsondan
left a comment
gibsondan
left a comment
There was a problem hiding this comment.
this is working but the resulting image looks a little weird to me in GHCR https://github.com/orgs/dagster-io/packages/container/dagster-cloud-action/463051166?tag=arm64-1.11.2
specifically this part
summary: The PEX is already set up to work on both amd64 and arm64, but users running our image (these days i think this is mostly just Gitlab users) on arm64 aren't able to use the built image. We could also do multi-platform builds but that seems non-trivial to set up in our CI, so starting with separate tags for now. stop using a PEX here
Contributor
|
Are you still waiting on review here or were you going to try to fix the "unknown/unknown" first? |
shalabhc
approved these changes
Aug 22, 2025
Contributor
shalabhc
left a comment
shalabhc
left a comment
There was a problem hiding this comment.
approving but not sure how to fix the unknown tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary:
The PEX is already set up to work on both amd64 and arm64, but users running our image (these days i think this is mostly just Gitlab users) on arm64 aren't able to use the built image.
We could also do multi-platform builds but that seems non-trivial to set up in our CI, so starting with separate tags for now.