Skip to content

Commit

Permalink
Use Pimcore AdminUserTranslator for Editable Dialog Box (#451)
Browse files Browse the repository at this point in the history
  • Loading branch information
pascalmoser authored Jun 17, 2024
1 parent 92e141b commit bf12c6d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
3 changes: 3 additions & 0 deletions UPGRADE.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Upgrade Notes

## 4.5.4
- **[BUGFIX]** Use Pimcore AdminUserTranslator for Editable Dialog Box [#450](https://github.com/dachcom-digital/pimcore-formbuilder/issues/450)

## 4.5.3
- **[BUGFIX]** [Backport]: Fix chunked upload

Expand Down
6 changes: 3 additions & 3 deletions src/FormBuilderBundle/Document/Areabrick/Form/Form.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
use Pimcore\Extension\Document\Areabrick\EditableDialogBoxConfiguration;
use Pimcore\Extension\Document\Areabrick\EditableDialogBoxInterface;
use Pimcore\Model\Document;
use Pimcore\Translation\Translator;
use Symfony\Contracts\Translation\TranslatorInterface;
use Symfony\Component\HttpFoundation\Response;

class Form extends AbstractAreabrick implements EditableDialogBoxInterface
Expand All @@ -21,14 +21,14 @@ class Form extends AbstractAreabrick implements EditableDialogBoxInterface
protected PresetManager $presetManager;
protected FormAssembler $formAssembler;
protected TemplateManager $templateManager;
protected Translator $translator;
protected TranslatorInterface $translator;

public function __construct(
FormDefinitionManager $formDefinitionManager,
PresetManager $presetManager,
FormAssembler $formAssembler,
TemplateManager $templateManager,
Translator $translator
TranslatorInterface $translator,
) {
$this->formDefinitionManager = $formDefinitionManager;
$this->presetManager = $presetManager;
Expand Down
4 changes: 3 additions & 1 deletion src/FormBuilderBundle/Resources/config/services/brick.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@ services:

# area brick
FormBuilderBundle\Document\Areabrick\Form\Form:
arguments:
$translator: '@Pimcore\Bundle\AdminBundle\Translation\AdminUserTranslator'
tags:
- { name: pimcore.area.brick, id: formbuilder_form }
- { name: pimcore.area.brick, id: formbuilder_form }

0 comments on commit bf12c6d

Please sign in to comment.