fix element type check in api channel (#429)

dachcom-digital · Jan 5, 2024 · 7430ff5 · 7430ff5
1 parent fdba349
commit 7430ff5
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 7 deletions.
diff --git a/.github/workflows/codeception.yml b/.github/workflows/codeception.yml
@@ -1,9 +1,9 @@
 name: Codeception
 on:
     push:
-        branches: [ 'master' ]
+        branches: [ '4.x' ]
     pull_request:
-        branches: [ 'master' ]
+        branches: [ '4.x' ]
 
 jobs:
     codeception:

diff --git a/.github/workflows/ecs.yml b/.github/workflows/ecs.yml
@@ -1,9 +1,9 @@
 name: Easy Coding Standards
 on:
     push:
-        branches: [ 'master' ]
+        branches: [ '4.x' ]
     pull_request:
-        branches: [ 'master' ]
+        branches: [ '4.x' ]
 
 jobs:
     ecs:

diff --git a/.github/workflows/php-stan.yml b/.github/workflows/php-stan.yml
@@ -1,9 +1,9 @@
 name: PHP Stan
 on:
     push:
-        branches: [ 'master' ]
+        branches: [ '4.x' ]
     pull_request:
-        branches: [ 'master' ]
+        branches: [ '4.x' ]
 
 jobs:
     stan:

diff --git a/UPGRADE.md b/UPGRADE.md
@@ -1,5 +1,8 @@
 # Upgrade Notes
 
+## 4.5.1
+- **[BUGFIX]**: Fix element type check in api channel [#423](https://github.com/dachcom-digital/pimcore-formbuilder/issues/423)
+
 ## Version 4.5.0
 - **[BUGFIX]**: allow `GET` operation on `/form-control/get-url-structure` route [#383](https://github.com/dachcom-digital/pimcore-formbuilder/issues/383)
 - **[BUGFIX]**: suppress php warning of undefined array key [@jheimbach](https://github.com/dachcom-digital/pimcore-formbuilder/pull/387)

diff --git a/src/FormBuilderBundle/OutputWorkflow/Channel/Api/ApiOutputChannelWorker.php b/src/FormBuilderBundle/OutputWorkflow/Channel/Api/ApiOutputChannelWorker.php
@@ -122,14 +122,16 @@ protected function buildApiNodes(array $nodes, array $formData, array $mapping,
             foreach ($apiMappingFields as $apiMappingField) {
 
                 $context = [
-                    'type'            => $formField['type'],
+                    'type'            => $formField['type'] ?? null,
                     'parentType'      => $hasParent ? $parentType : null,
                     'formData'        => $formData,
                     'formField'       => $formField,
                     'apiMappingField' => $apiMappingField,
                 ];
 
                 $nodes[$apiMappingField] = $this->findFormFieldValue($formField, $fieldTransformer, $context);
+
+                unset($apiMappingField);
             }
 
             if ($hasChildren) {