HW: PyVCAM adapter #108
HW: PyVCAM adapter #108
Conversation
Updated camera init to allow initialization by specific name. If name is not provided, the next available camera is opened. Removed some properties from __init__. I think it will be better to set these after init. We should be able to open the camera without specifying too many extra parameters. Added methods for setting the camera readout speed and gain by name, rather than by index.
| def __init__( | ||
| self, | ||
| camera_name: str = None, | ||
| # TODO: create properties for these |
There was a problem hiding this comment.
I think these shouldn't be properties. You mentioned you don't want to change these attributes often but more like you want to set it at the beginning only. That's why I intended to have them have them as arguments here instead of properties. What do you think @ieivanov ?
There was a problem hiding this comment.
Ah, I see your point. I think we should keep the __init__ as simple as possible. We often don't know what are possible values for these properties and need to initialize the camera to find out. Also, we occasionally change them after we start up the camera - it would be inconvenient to have to unload the camera to change these properties.
There was a problem hiding this comment.
That's alright, as soon as these values are member attributes we can change them later anytime and we will need a camera restart method anyway which we can use to update these attributes on the lower level driver APIs. We can revisit this once this class implementation is closer to the end.
|
|
||
| @property | ||
| def speed_gain_table(self): | ||
| return self._speed_gain_table |
There was a problem hiding this comment.
given the _speed_gain_table value won't change, I think this can be defined as a class attribute instead of property. What do you think @ieivanov ?
There was a problem hiding this comment.
Sounds good! By hardcoding this table we're making this class specific to the Prime BSI Express camera, which was our original intention. At a later point we can parse this table from port_speed_gain_table['CMOS'] to make the class generalize to other PVCAM cameras.
There was a problem hiding this comment.
absolutely, or we might have separate adapters for the other PVCAM cameras. Either way will be easy to accommodate those.
2 participants
This PR adds the camera adapter required for using prime bsi camera and the initial form of the camera gui dockable widget. Eventually, we should be able to populate the parameters on that camera dockable widget with the exposed options of the related camera adapter instance. This is currently not implemented. Before merging the PR, we should also add a demo for the prime bsi camera and test it on the automaton machine.