CORE-2017: multi-year and future subscriptions #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slr71
requested review from
johnworth,
ianmcorvidae,
psarando,
tedgin and
suemkwon
|
I don't see a Chromatic build associated with this PR. Is it enabled in your fork? |
|
Hmm, I thought it was. 🤔 |
|
Ah, never mind. I had actions disabled on my fork to prevent the build actions from running. |
|
I just pushed a change to force a chromatic build. |
psarando
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Ah, yeah, I sometimes disable only the Chromatic action, so commits to my fork don't create unnecessary builds (using up some of our monthly snapshot quota), until I'm ready to open a PR.
This looks good so far, but I think I caught a bug for editing subscriptions with existing start and end dates.
| : undefined, | ||
| end_date: end_date | ||
| ? formatDateObject(new Date(end_date), dateConstants.ISO_8601) | ||
| : undefined, |
|
Thanks for the review! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the following fields to the subscription edit form.