Skip to content

bump to node 20 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

bump to node 20 #70

wants to merge 5 commits into from
+3 −2

Conversation

@jennifer-shehane
Copy link
Member

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

MikeMcC399
MikeMcC399 reviewed Sep 6, 2024
View reviewed changes
@MikeMcC399
Copy link

This PR fails due to

  1. Non-existent CircleCI Docker image
  2. test fails in all current Node.js versions #68

MikeMcC399
MikeMcC399 suggested changes Sep 6, 2024
View reviewed changes
Copy link

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to use an available cimg/node Docker image.

@jennifer-shehane @MikeMcC399
Update .circleci/config.yml
4a8cc40 
Co-authored-by: Mike McCready <[email protected]>
@jennifer-shehane
Copy link
Member Author

@MikeMcC399 Thanks.

@jennifer-shehane
Copy link
Member Author

Alright, I have this properly failing on this PR now for possible investigation.

@jennifer-shehane jennifer-shehane self-assigned this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MikeMcC399 MikeMcC399 MikeMcC399 requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@jennifer-shehane jennifer-shehane

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jennifer-shehane @MikeMcC399