fix(navigation): resolve wait on canceled requests #32309
+55
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
I left a
TODOwith some questions that hopefully someone can answer.Steps to test
Revert the fix and check that the test fails.
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?Note
Marks in-flight requests as errored at navigation start so
cy.wait('@alias')resolves when the underlying request is canceled by navigation; adds test and changelog entry.requestsandaliasedRequestsas canceled on navigation start by settingrequest.state = 'Errored'and attaching anerrorinstabilityChanged()withinpackages/driver/src/cy/commands/navigation.ts.packages/driver/cypress/e2e/commands/navigation.cy.jsverifyingcy.wait('@alias')resolves after a navigation-canceled request.cli/CHANGELOG.mdforcy.wait('@alias')timing out on navigation-canceled requests.consoleinpackages/electron/src/print-node-version.ts.Written by Cursor Bugbot for commit f670c41. This will update automatically on new commits. Configure here.