Skip to content

misc: Reporter redesign #31914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 74 commits into
base: release/15.0.0
Choose a base branch
from

Conversation

mabela416
Copy link
Contributor

@mabela416 mabela416 commented Jun 18, 2025

Additional details

Steps to test

Go through different states of the app and make sure the styles match the figma

image

image

image

How has the user experience changed?

PR Tasks

@mabela416 mabela416 changed the base branch from develop to release/15.0.0 June 23, 2025 15:09
@jennifer-shehane jennifer-shehane changed the title feat: Reporter redesign misc: Reporter redesign Jun 23, 2025
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mabela416 So many changes, thanks for seeing this work through! I have some comments on a few things initially.

On hover of commands, there is a slight rounded corner on all of the right corners, when there shouldn't be for corners that are not first/last.

Screenshot 2025-06-23 at 11 26 09 AM

Is it possible to have this bottom left corner look more rounded when the test is open?

Screenshot 2025-06-23 at 11 29 51 AM

Is this the right hover state for tests? I assumed it would be this lighter focus style.

Screenshot 2025-06-23 at 11 54 38 AM
Screenshot 2025-06-23 at 11 55 40 AM

This juxtaposition of the failure block with the test logs looks strange to me.

Screenshot 2025-06-23 at 11 52 36 AM

When you hover over a describe, the icon changes to an arrow, but when you click the describe - that arrow icon doesn't rotate to show the described as closed.

Screenshot 2025-06-23 at 11 57 34 AM
Screenshot 2025-06-23 at 11 58 30 AM

Also, the icon stays that way after click/focus and does not go back to the old icon when I hover away from the describe. Seems odd.

The 'Open in IDE' button when hovering over a Before Each doesn't seem centered.

Screenshot 2025-06-23 at 11 59 37 AM

The jump that the test does from the 1px border to the 2px border doesn't feel fluid.

Screen.Recording.2025-06-23.at.12.00.38.PM.mov

We need some margin-bottom on the tests list - when you scroll all the way down it sits there so close to the bottom edge like it's not the end.

Screenshot 2025-06-23 at 12 04 25 PM

I don't think the New Test button should overlap the text of the Describe, it's a bit weird copying the text or seeing it if I want in this case.

Screenshot 2025-06-23 at 12 06 06 PM
Screenshot 2025-06-23 at 12 06 01 PM

The attempt styling needs to be accounted for - the lines connecting them look strange here.

Screenshot 2025-06-23 at 12 07 37 PM

This describe icon feels strange flashing back and forth between pending/queued? Maybe it's not too weird, I don't know.

Screen.Recording.2025-06-23.at.12.10.12.PM.mov

This blue line that shows on the commandTimeout - when it burns down should have that highlighted gray color, not the dark black color.

Screen.Recording.2025-06-23.at.12.12.59.PM.mov

@mabela416
Copy link
Contributor Author

@mabela416 So many changes, thanks for seeing this work through! I have some comments on a few things initially.

Is this the right hover state for tests? I assumed it would be this lighter focus style.

Screenshot 2025-06-23 at 11 54 38 AM Screenshot 2025-06-23 at 11 55 40 AM

Yeah this is the figma for the test hover state https://www.figma.com/design/XYBgOykHfLCi1yT4Va7GLO/Studio-Test-generation?node-id=3607-170837&t=33uO9ue4ojx1TNL4-4

The lighter focus style is only for when the user focuses the test by tabbing

@mabela416
Copy link
Contributor Author

@mabela416 So many changes, thanks for seeing this work through! I have some comments on a few things initially.

I don't think the New Test button should overlap the text of the Describe, it's a bit weird copying the text or seeing it if I want in this case.

Screenshot 2025-06-23 at 12 06 06 PM Screenshot 2025-06-23 at 12 06 01 PM

This is part of the design here

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update reporter UI to remove nesting + show full describes
2 participants