feat(other): integrate advanced search into saved searches module set #1738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroky
reviewed
Oct 13, 2025
|
@IrAlfred thanks, it looks good but can you please add some unit/integration tests to cover the new functionality? |
IrAlfred
force-pushed
the
integrate-advanced-search-into-saved-searches
branch
2 times, most recently
from
77eebbe to
abce26c
Compare
IrAlfred
force-pushed
the
integrate-advanced-search-into-saved-searches
branch
from
abce26c to
afa4d24
Compare
kroky
reviewed
Oct 17, 2025
| public function setUp(): void { | ||
| require_once __DIR__.'/../../bootstrap.php'; | ||
| require_once APP_PATH.'modules/core/modules.php'; | ||
| require_once APP_PATH.'modules/saved_searches/modules.php'; |
There was a problem hiding this comment.
These three lines are inappropriately placed here. They should be part of the test suite bootstrap process.
kroky
reviewed
Oct 17, 2025
| ) | ||
| ); | ||
|
|
||
| $this->saved_searches = new Hm_Saved_Searches($this->sample_data); |
There was a problem hiding this comment.
If you initialize this here, why do you keep initializing it in individual tests and not just reuse?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #306