expire: fix interaction with automatic retries

[oliver-sanders]

• Closes expire: bad interaction with automatic retries #6717

(Note, this issue needs to be resolved before expire triggers can be used in anger)

Check List

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
• Tests are included (or explain why tests are not needed).
• Changelog entry included if this is a change that can affect users
• Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
• If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

[oliver-sanders]

@hjoliver, is this a valid use of the force argument?

Looks like the tutorial workflow tests failed as this change removed the (internal) prefix from the expired log message.

[hjoliver]

I think it's valid, but maybe update the docstring in the message to say that expiry counts as forcing too.

Do we also need this for suicide-induced task expiry? (See line 1565)

[oliver-sanders]

The message currently reads:

cylc-flow/cylc/flow/task_events_mgr.py

Lines 720 to 721 in 89efa74

	forced:
	If this message is due to manual completion or not (cylc set)

So, should this be:

If this message was set for internal (i.e, artificial) as opposed to natural satisfaction.

If so, are there any other situations we should be using this in?

[oliver-sanders]

(rebased)