Fix conn reset handling for go 1.6.1 #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using go 1.6.1, after adding some debug, I find: ne.Err.Error() is "read: connection reset by peer" but syscall.ECONNRESET.Error() is "connection reset by peer" They are not equal, so I make this fix to work around. Since 0.9.7 build is also built with go 1.6.1, I think it is the root cause causing cyfdecyf#445 cyfdecyf#454
|
Thank you for the PR. |
|
@Smallthing I guess the same fix should also work for Windows, but I don't have any Windows machines or VMs to test it. |
|
@Smallthing You can try my PR #465 for windows |
Laisky
pushed a commit
to Laisky/cow
that referenced
this pull request
Oct 25, 2022
Fix conn reset handling for go 1.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using go 1.6.1, after adding some debug, I find:
ne.Err.Error() is "read: connection reset by peer"
but syscall.ECONNRESET.Error() is "connection reset by peer"
They are not equal, so I make this fix to work around.
Since 0.9.7 build is also built with go 1.6.1, I think it is the root cause causing issue #445 #454