fix: [docker] use valkey in docker-compose #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oh2fih
reviewed
Mar 26, 2025
docker/docker-compose.yml
Outdated
| image: "valkey/valkey:alpine" |
There was a problem hiding this comment.
Does this work in-place without additional migration steps? I think it would, as cpe-guesser does not need much persistence.
There was a problem hiding this comment.
Might as well add the missing newline to the end of this text file.
There was a problem hiding this comment.
- It works without any other migration steps.
- Added the missing newline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
docker-composeto maintain compatibility with the repositorysettings.yamlfor docker-compose