Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NvdNistApi urllib3 1.x backwards compatibility #264

Merged
merged 3 commits into from
Apr 2, 2024
Merged

NvdNistApi urllib3 1.x backwards compatibility #264

merged 3 commits into from
Apr 2, 2024

Conversation

oh2fih
Copy link
Collaborator

@oh2fih oh2fih commented Apr 2, 2024 •
edited
Loading

Fixes the compatibility issue (cve-search#1064) with urllib3 1.x, as backoff_max for urllib3.util.retry was added in 2.0.0.

Tested on Ubuntu 22.04 with python3-urllib3 version 1.26.5-1~exp1ubuntu0:

CveXplore.core.database_maintenance.main_updater - INFO     - Starting Database population....
CveXplore.core.nvd_nist.nvd_nist_api - INFO     - NVD NIST API Key found!
CveXplore.core.database_maintenance.sources_process - INFO     - CPE Database population started
CveXplore.core.database_maintenance.sources_process - INFO     - Starting download...
CveXplore.core.nvd_nist.nvd_nist_api - INFO     - urllib3.util.retry did not support configurable backoff_max; falling back to default for urllib3 1.x compatibility
CveXplore.core.database_maintenance.sources_process - INFO     - Preparing to download 1263712 CPE entries

@oh2fih oh2fih force-pushed the urllib3-1-compatibility branch from 9d6a8c8 to b3f34e6 Compare April 2, 2024 15:53
@oh2fih oh2fih mentioned this pull request Apr 2, 2024
Closed
@P-T-I
Copy link
Member

P-T-I commented Apr 2, 2024

Awesome! Thanks!!

@P-T-I P-T-I merged commit bb44ca5 into cve-search:master Apr 2, 2024
3 checks passed
@oh2fih oh2fih deleted the urllib3-1-compatibility branch April 2, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oh2fih @P-T-I