✨ feat: allow ignore components, sources

[huynhducduy]

• Support ignore specific components, specific components imported from sources, or all components imported from sources
• Close Disable rule for react-router-dom <Route/> element. #67

[huynhducduy]

Please remember to change the version (v3.4.0) to your desired one

[harshVardhan4743]

Hi @huynhducduy , when can we expect to get it merged ? 🙏

[huynhducduy]

Hi @huynhducduy , when can we expect to get it merged ? 🙏

@harshVardhan4743 Sorry but I don't know when @cvazac has the time to review it. At the mean time, you can try this PR and all of my other PRs by using this patch https://gist.github.com/huynhducduy/46515b884c583e9ad95a353829010638

[cvazac]

I think you can just do this:

const ignoreComponentsSet = new Set(ignoreComponents || []);

[cvazac]

Thanks for working on this @huynhducduy!

Today, we have nativeAllowList. Soon we will have allowList. For consistency, maybe ignoreComponents should be componentAllowList and ignoreImports should be importAllowList - wdyt?

[cvazac]

would it make sense to instead namespace as importNames: ["Foo.Item"]? wdyt?

[huynhducduy]

Do you mean to drop the source property?

[cvazac]

I think we need to adjust the config to be able to, for example, allow the known patterns for Foo.Item, but disallow for Bar.Item.

import Foo from "react-foo"
import Bar from "react-bar"

render() {
  return <><Foo.Item /><Bar.Item /></>
}

The options in the PR on line 118 don't distinguish between Foo and Bar.

[huynhducduy]

Hmm, I didn't get it yet. It does disallow for Bar.Item since Bar is imported from react-bar (not react-foo).

[huynhducduy]

@cvazac have I answered all your questions? Is there anything else you are unclear about?

[huynhducduy]

Thanks for working on this @huynhducduy!

Today, we have nativeAllowList. Soon we will have allowList. For consistency, maybe ignoreComponents should be componentAllowList and ignoreImports should be importAllowList - wdyt?

IMO, the allowList postfix will be used for props (allowList for React component's props, nativeAllowList for native component's props).
If we use that postfix, it can be misleading. That's why I choose ignore instead.

This is also my answer for #73 (comment)