engine: accept contextual images from file share in path validator #9984
Conversation
Fixes cvat-ai#9978 - Allow related/context images from SHARE root - Keep normalized, relative paths for safety - Preserves traversal protections
- Replace generic Exception with ValueError - Add explicit None check for share_root - Add validation for empty paths - Add docstring for clarity - Improve error messages Addresses SonarQube reliability issues
|
|
Hi, thank you for the PR. Please add at least 1 test to check if the changes work correctly and there are no regressions in the future. Please also keep in mind that there's another PR that tries to address this issue: #9985. I think, it will be better to focus each PR on just 1 problem. |
| # Get share root directory | ||
| share_root = None | ||
| if hasattr(db_data, 'get_share_root'): | ||
| share_root = db_data.get_share_root() |
There was a problem hiding this comment.
What is this method? There is no get_share_root() method in the whole repository.
There was a problem hiding this comment.
Please check the comments in the other PR. There are good ideas in both implementations, let's make the combined version.
2 participants
No description provided.