Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Let function create-native submit label types to the server #9035

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Jan 31, 2025

Motivation and context

This will enable more accurate label type information in the function API, which is used in a few places (for example, in the "From model" feature available when configuring labels for a task).

How has this been tested?

There will be tests in the private repo.

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@SpecLad
Copy link
Contributor Author

SpecLad commented Jan 31, 2025

This depends on a change in the private repository; I'll keep it as a draft until that change is merged.

@SpecLad SpecLad force-pushed the native-function-label-type branch from be87003 to 567a46f Compare February 7, 2025 13:41
@SpecLad SpecLad marked this pull request as ready for review February 7, 2025 13:41
@SpecLad SpecLad requested a review from nmanovic as a code owner February 7, 2025 13:41
Copy link

sonarqubecloud bot commented Feb 7, 2025

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.92%. Comparing base (1a90c5f) to head (567a46f).
Report is 23 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9035      +/-   ##
===========================================
+ Coverage    73.40%   73.92%   +0.52%     
===========================================
  Files          418      428      +10     
  Lines        44315    44530     +215     
  Branches      3870     3881      +11     
===========================================
+ Hits         32530    32920     +390     
+ Misses       11785    11610     -175     
Components Coverage Δ
cvat-ui 77.46% <ø> (+0.07%) ⬆️
cvat-server 71.00% <ø> (+0.91%) ⬆️

@SpecLad SpecLad merged commit fb3bde4 into cvat-ai:develop Feb 7, 2025
42 checks passed
@SpecLad SpecLad deleted the native-function-label-type branch February 7, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants