Skip to content

Conversation

@klakhov
Copy link
Contributor

@klakhov klakhov commented Nov 19, 2025

Motivation and context

Refactored code so when we click elements like links default browser context menu is opened, not card context menu

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Copy link
Member

@bsekachev bsekachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally seems reasonable, but maybe use onClickCapture instead to cover somehow use-case with ctrl/cmd + click to open in another tab

@sonarqubecloud
Copy link

@klakhov
Copy link
Contributor Author

klakhov commented Nov 26, 2025

I updated PR to apply new approach for all cards.

I dont think we can use onClickCapture to cover ctrl+click opening in new tab as it is capturing right clicks, not left clicks.

ctrl+left click works fine even now, but only for Link components. So its applicable now only for job item id link and task item open link. I think we need to add links on job card and project card to cover this case. If I remember correctly before bulk actions we used preview as a link, but now it would be confusing so its better to use id or name for link element.

@klakhov klakhov marked this pull request as ready for review November 26, 2025 09:12
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@18e761a). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10019   +/-   ##
==========================================
  Coverage           ?   82.30%           
==========================================
  Files              ?      428           
  Lines              ?    46228           
  Branches           ?     4136           
==========================================
  Hits               ?    38046           
  Misses             ?     8182           
  Partials           ?        0           
Components Coverage Δ
cvat-ui 77.50% <88.88%> (?)
cvat-server 86.36% <ø> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants