-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Allow to open browser context menu on right click in resource cards #10019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
bsekachev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally seems reasonable, but maybe use onClickCapture instead to cover somehow use-case with ctrl/cmd + click to open in another tab
|
|
I updated PR to apply new approach for all cards. I dont think we can use ctrl+left click works fine even now, but only for |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #10019 +/- ##
==========================================
Coverage ? 82.30%
==========================================
Files ? 428
Lines ? 46228
Branches ? 4136
==========================================
Hits ? 38046
Misses ? 8182
Partials ? 0
🚀 New features to boost your workflow:
|



Motivation and context
Refactored code so when we click elements like links default browser context menu is opened, not card context menu
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.