Support plugins for job menu and player #10012
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #10012 +/- ##
===========================================
+ Coverage 73.89% 82.52% +8.62%
===========================================
Files 428 428
Lines 46260 46278 +18
Branches 4137 4138 +1
===========================================
+ Hits 34184 38191 +4007
+ Misses 12076 8087 -3989
🚀 New features to boost your workflow:
|
| max={stopFrame} | ||
| onChange={(value) => { | ||
| removeFrom = value; | ||
| removeFrom = value ?? undefined; |
There was a problem hiding this comment.
Why do we need these two changes?
If value is not specified, it is already undefined or null.
There was a problem hiding this comment.
We have ts error here, value from on change can be null, and the method removeAnnotationsAsyncAction and jobInstance.annotations.clear support only number | undefined
There was a problem hiding this comment.
Should not we fix types in jobInstance.annotations.clear instead?
BTW removeAnnotationsAsync always expects numbers according to specified types, so, the types are inconsistent anyway
There was a problem hiding this comment.
jobInstance.annotations.clear accept number | undefined for those params and have separate logic for handling such case (clearing all annotations). So I suppose the correct way should be changing types here and in removeAnnotationsAsync.
| plugins: [ | ||
| '@babel/plugin-proposal-class-properties', | ||
| '@babel/plugin-proposal-optional-chaining', | ||
| '@babel/plugin-transform-private-methods', |
There was a problem hiding this comment.
Could you please clarify why we need this plugin?
There was a problem hiding this comment.
This plugin allow us to define private class methods with # notation, like this: #doSomething(param: number): void, without it only private fields are allowed: this.#field.
cvat-ui/src/components/annotation-page/top-bar/player-navigation.tsx
Outdated
Show resolved
Hide resolved
|
Motivation and context
This PR adds plugin support for job annotation view menu and player.
Also splitted logic for fetching and decoding contextImages into two separate methods
How has this been tested?
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.