Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bill payments 💲 #289

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Bill payments 💲 #289

wants to merge 6 commits into from

Conversation

andreshndz
Copy link
Contributor

@andreshndz andreshndz commented Sep 8, 2022

Allowing to create BillPayments and queries for ServiceProviders

@andreshndz andreshndz self-assigned this Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #289 (3c8ca60) into main (4bfdf7c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #289   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1154      1174   +20     
=========================================
+ Hits          1154      1174   +20     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cuenca_validations/types/__init__.py 100.00% <100.00%> (ø)
cuenca_validations/types/enums.py 100.00% <100.00%> (ø)
cuenca_validations/types/files.py 100.00% <100.00%> (ø)
cuenca_validations/types/queries.py 100.00% <100.00%> (ø)
cuenca_validations/types/requests.py 100.00% <100.00%> (ø)
cuenca_validations/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfdf7c...3c8ca60. Read the comment docs.

@andreshndz andreshndz marked this pull request as ready for review September 9, 2022 21:14
Copy link
Member

@alexviquez alexviquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amount debe ser positivo

@@ -1 +1 @@
__version__ = '0.11.0'
__version__ = '0.11.2.dev1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v

Comment on lines 653 to 654
class BillPaymentRequest(BaseRequest):
amount: int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

positive int y no puede ser 0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usa los tipos de pydantic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants