refactor: rework core and util
#154
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djsigmann
force-pushed
the
refactor-core
branch
from
8d84913 to
2ef83ca
Compare
djsigmann
changed the title
core and utilcore and util
djsigmann
force-pushed
the
refactor-core
branch
from
2ef83ca to
2c2d771
Compare
cueki
reviewed
Dec 22, 2025
djsigmann
force-pushed
the
refactor-core
branch
12 times, most recently
from
23fea4b to
61e5e57
Compare
djsigmann
force-pushed
the
refactor-core
branch
4 times, most recently
from
7bf4cbc to
a8a1167
Compare
djsigmann
force-pushed
the
refactor-core
branch
5 times, most recently
from
7b7740f to
a902046
Compare
cueki
reviewed
Jan 11, 2026
cueki
approved these changes
Jan 12, 2026
Generally rework some of those functions and move related functions into their own submodules.
djsigmann
force-pushed
the
refactor-core
branch
from
00442df to
9c9cd7b
Compare
cueki
reviewed
Jan 12, 2026
djsigmann
force-pushed
the
refactor-core
branch
2 times, most recently
from
36217ad to
f150e3e
Compare
Also add missing executable bits and shebangs to scripts.
Most notably, move all logic for downloading the modpack to `core`.
Also dynamically set attrs in `FolderConfig`. Directories should be created/checked for existence when needed. Using `Path` objects directly is usually cleaner than using complex methods.
djsigmann
force-pushed
the
refactor-core
branch
from
f150e3e to
4cbcce2
Compare
Also dynamically set attrs in `FolderConfig`. Directories should be created/checked for existence when needed. Using `Path` objects directly is usually cleaner than using complex methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.