Skip to content

Convert parameterized objects with @DefaultDataTableEntryTransformer #2995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jean-tissot
Copy link
Contributor

Fixes: #2994

@jean-tissot
Copy link
Contributor Author

Hello,
I don't know if this bug fix should be added to the changelog so I didn't add it. I can do it if necessary (is it a [Core] fix or a [Java] fix ?)

@mpkorstanje
Copy link
Contributor

That's okay! It's a [Core] fix. The [Java] fix would be used for cucumber-java module. A bit confusing but we also had cucumber-scala, cucmber-groovy and a few others.

@mpkorstanje mpkorstanje changed the title fix: convert parameterized objects correctly with @DefaultDataTableEntryTransformer Convert parameterized objects with @DefaultDataTableEntryTransformer May 11, 2025
@mpkorstanje mpkorstanje force-pushed the fix/2994-convert-parameterized-type branch from b779b07 to 5eba581 Compare May 11, 2025 22:43
@mpkorstanje mpkorstanje merged commit 4616a21 into cucumber:main May 11, 2025
6 checks passed
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On review, I only had one small remark. Which was easy enough to fix along with the changelog.

So thanks for the PR! This allowed me to release the fix today.

Should be available once https://github.com/cucumber/cucumber-jvm/actions/runs/14960479934/job/42021698326 completes.

@jean-tissot
Copy link
Contributor Author

I saw your fix. Indeed, I didn't think of this to make bugs easier to find when the test fails.
Thanks for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failing when using a parameterized type in a cucumber step with
2 participants