Set FORCE_COLOR based on deprecated format option#2769
Draft
davidjgoss wants to merge 3 commits intomainfrom
Draft
Set FORCE_COLOR based on deprecated format option#2769davidjgoss wants to merge 3 commits intomainfrom
davidjgoss wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
When we detect a value has been set (either
trueorfalse) for thecolorsEnabledformat option, set theFORCE_COLORenvironment variable to the corresponding value.⚡️ What's your motivation?
We're moving away from this custom option and leaning into the pseudo-standard environment variable. This is an intermediate step before we remove the option entirely, so existing usages will cause the environment variable to be set, and all formatters will still work as expected.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.