fix: ensure feature paths are properly deduplicated (#2258)

CHANGELOG.md

@@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CONTRIBUTING.md) on how to contribute to Cucumber.
 
 ## [Unreleased]
+### Fixed
+- Ensure feature paths are properly deduplicated ([#2258](https://github.com/cucumber/cucumber-js/pull/2258))
 
 ## [9.0.0] - 2023-02-27
 ### Removed

src/api/paths.ts

@@ -73,7 +73,8 @@ async function expandPaths(
       return expanded.flat()
     })
   )
-  return expandedPaths.flat().map((x) => path.normalize(x))
+  const normalized = expandedPaths.flat().map((x) => path.normalize(x))
+  return [...new Set(normalized)]
 }
 
 async function getUnexpandedFeaturePaths(
@@ -126,7 +127,6 @@ async function expandFeaturePaths(
   featurePaths: string[]
 ): Promise<string[]> {
   featurePaths = featurePaths.map((p) => p.replace(/(:\d+)*$/g, '')) // Strip line numbers
-  featurePaths = [...new Set(featurePaths)] // Deduplicate the feature files
   return await expandPaths(cwd, featurePaths, '.feature')
 }
 

src/api/paths_spec.ts

@@ -55,7 +55,31 @@ describe('resolvePaths', () => {
       expect(importPaths).to.eql([esmSupportCodePath])
     })
 
-    it('deduplicates the .feature files before returning', async function () {
+    it('deduplicates features based on overlapping expressions', async function () {
+      // Arrange
+      const cwd = await buildTestWorkingDirectory()
+      const relativeFeaturePath = path.join('features', 'a.feature')
+      const featurePath = path.join(cwd, relativeFeaturePath)
+      await fsExtra.outputFile(featurePath, '')
+      // Act
+      const { featurePaths } = await resolvePaths(
+        new FakeLogger(),
+        cwd,
+        {
+          paths: ['features/*.feature', 'features/a.feature'],
+        },
+        {
+          requireModules: [],
+          requirePaths: [],
+          importPaths: [],
+        }
+      )
+
+      // Assert
+      expect(featurePaths).to.eql([featurePath])
+    })
+
+    it('deduplicates features based on multiple targets of same path', async function () {
       // Arrange
       const cwd = await buildTestWorkingDirectory()
       const relativeFeaturePath = path.join('features', 'a.feature')