Gherkin Java - Remove unused private property #1895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I spotted this private property while working on the PHP implementation. It has no code that writes to it1 so AFAICS is always false, so effectively dead code.
It was made private in #1879 and nothing broke, so presumably it didn't have any external access points.
How Has This Been Tested?
Behaviour is invisible, so no test changes
Screenshots (if appropriate):
Types of changes
Checklist:
I have not taken the time to check the other implementations - I did look at dotnet where it has {get, set} so may be public
Footnotes
Unless there's some Java way of doing this I don't know about ↩