Skip to content

Gherkin Java - Remove unused private property #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ciaranmcnulty
Copy link
Contributor

@ciaranmcnulty ciaranmcnulty commented Feb 7, 2022

Details

I spotted this private property while working on the PHP implementation. It has no code that writes to it1 so AFAICS is always false, so effectively dead code.

It was made private in #1879 and nothing broke, so presumably it didn't have any external access points.

How Has This Been Tested?

Behaviour is invisible, so no test changes

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

I have not taken the time to check the other implementations - I did look at dotnet where it has {get, set} so may be public

Footnotes

  1. Unless there's some Java way of doing this I don't know about

@ciaranmcnulty ciaranmcnulty merged commit 71c8aa8 into cucumber:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants