(messages) better class splitting in PHP version #1894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a better approach in the Java version, so copying it (and fixing a minor error)
ciaranmcnulty
force-pushed
the
messages-php-better-splitting
branch
from
d6ea673 to
a005d73
Compare
ciaranmcnulty
commented
Feb 5, 2022
| csplit --quiet --prefix=build/Generated --suffix-format=%02d.php.tmp --elide-empty-files build/messages.php /^.*[.]php$$/ {*} | ||
| rm build/messages.php | ||
| rm -rf src-generated/* | ||
| for file in build/Generated**; do mkdir -p src-generated/$$(head -n 1 $$file | sed 's/[^/]*.php$$//'); done |
There was a problem hiding this comment.
This is required to make the subfolders - the sed ends up trying to make src-generated/ a bunch of times but I think it's harmless
|
Nice :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the PHP script responsible for message class splitting
#1879 introduced a better csplit-driven approach in the Java version, so copying it (and fixing a minor error)