-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable HPWHsim heat-exchange models #448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the only need for this PR is to support AquaThermAire and there are no CSE results changes, I think this should be merged.
I assume Neal has reviewed the extensive changes on the hpwhsim side?
When do the hpwhsim changes get merged into the other hpwhsim branches that are in play?
@chipbarnaby and @spahrenk, I think this one should be closed in favor of #445. Is there anything on this branch that needs to be added there? |
@spahrenk This branch needs |
Attempted to merge main and update submodules. |
Description
bool hasHeatExchanger
double heatExchangeEffectiveness
Test dhw_aquathermaire.cse is added to the regression set.
Author Progress Checklist:
Reviewer Checklist: