Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HPWHsim heat-exchange models #448

Merged
merged 18 commits into from
Jan 10, 2024
Merged

Conversation

spahrenk
Copy link
Contributor

@spahrenk spahrenk commented Dec 6, 2023

Description

  • Applies the heat-exchange-models branch of HPWHsim., which is described in the HPWHsim PR: Heat exchange models bigladder/HPWHsim#183.
  • The heat-exchange model AquaThermAire is available as both a preset and a file. An accompanying test named villara_24h67 is included for application with this model. All tests are passed in HPWHsim and cse.
  • A simple heat-exchange mechanism is used in this model. Two new parameters are defined:
    bool hasHeatExchanger
    double heatExchangeEffectiveness

Test dhw_aquathermaire.cse is added to the regression set.

Author Progress Checklist:

  • Open draft pull request
    • Make title clearly understandable in a standalone change log context
    • Assign yourself the issue
    • Add at least one label (enhancement, bug, or maintenance)
    • Link the issue(s) addressed by this PR (under "Development" in the sidebar menu)
  • Make code changes (if you haven't already)
  • Self-review of code
    • My code follows the style guidelines of this project
    • I have added comments to my code, particularly in hard-to-understand areas
    • I have only committed the necessary changes for this fix or feature
    • I have made corresponding changes to the documentation
    • My changes generate no new warnings
    • I have ensured that my fix is effective or that my feature works as intended by:
      • exercising the code changes in the test framework, and/or
      • manually verifying the changes (as explained in the the pull request description above)
    • My changes pass all local tests
    • My changes successfully passes CI checks
    • Add any unit test for proof and documentation.
    • Merge in main branch and address resulting conflicts and/or test failures.
  • Move pull request out of draft mode and assign reviewers
  • [] Iterate with reviewers until all changes are approved
    • Make changes in response to reviewer comments
    • Merge in main branch and address resulting conflicts and/or test failures.
    • Re-request review in GitHub

Reviewer Checklist:

  • Read the pull request description
  • Perform a code review on GitHub
  • Confirm all CI checks pass and there are no build warnings
  • Pull, build, and run automated tests locally
  • Perform manual tests of the fix or feature locally
  • Add any review comments, if applicable
  • Submit review in GitHub as either
    • Request changes, or
    • Approve
  • Iterate with author until all changes are approved

@spahrenk spahrenk self-assigned this Dec 6, 2023
Copy link
Contributor

@chipbarnaby chipbarnaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the only need for this PR is to support AquaThermAire and there are no CSE results changes, I think this should be merged.

I assume Neal has reviewed the extensive changes on the hpwhsim side?

When do the hpwhsim changes get merged into the other hpwhsim branches that are in play?

@nealkruis
Copy link
Contributor

@chipbarnaby and @spahrenk, I think this one should be closed in favor of #445. Is there anything on this branch that needs to be added there?

@nealkruis
Copy link
Contributor

@spahrenk This branch needs main merged in, and needs to update the HPWHsim submodule to its main.

@spahrenk
Copy link
Contributor Author

spahrenk commented Jan 9, 2024

Attempted to merge main and update submodules.

@nealkruis nealkruis merged commit 51ebe66 into main Jan 10, 2024
2 checks passed
@nealkruis nealkruis deleted the heat-exchange-models-hpwh branch January 10, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants