Skip to content

Conversation

@mcflugen
Copy link
Member

I've removed some wording in the description of get_var_grid that said grid ids start at 0. In fact, they can be any integer at all.

@mcflugen mcflugen changed the title grid identifiers don't have to start at zero Grid identifiers don't have to start at zero May 31, 2025
@mcflugen mcflugen requested a review from Copilot May 31, 2025 23:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the documentation for get_var_grid by removing an outdated note that grid identifiers must start at 0, since they can be any integer.

  • Removed the misleading implementation note about zero-based grid IDs.
Comments suppressed due to low confidence (1)

docs/source/bmi.var_funcs.md:57

  • [nitpick] Consider adding a replacement note clarifying that grid identifiers can be any integer value, e.g., 'Grid identifiers can be any integer, not necessarily starting at 0.'
-- Grid identifiers start at 0.

@mcflugen mcflugen requested a review from mdpiper May 31, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants