don't separately test initialize(); allow testing even if initial value of array is NaN #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue of array is NaN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three suggested changes:
Re-ordered text around the non-testing of test_get_value(self) [Purely cosmetic]
Removed the test of initialize() because this is done in the setup before every test. And it was failing when I wasn't passing a config file to the routine because I was testing a BMI routine that could use, but didn't need, a specified config file
In order to test get/set at indices, bmi-tester gets an array's values, increments the first value, and set's the first indices to that value. But I had initialized the arrays to NaN -- actually np.nan -- so the increment operation was causing an error. I import the math module to get access to math.isnan() so I can check for this condition and instead use the value "1" as the value that gets used in set_value_at_indices().