Skip to content

Add partially-modernized ocaml hw03 harness #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

bennostein
Copy link
Contributor

partially apply csci5535/hw02#2; add type signatures for PFPL PCF definitions.

Copy link
Member

@bechang bechang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge with minor edits.

#require "core";;
#require "oUnit";;
#directory "_build";;
#load "hw02.cma";;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#load "hw02.cma";;
#load "hw03.cma";;

@@ -0,0 +1,36 @@
# hw02/ocaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# hw02/ocaml
# hw03/ocaml

| Prod of typ * typ
| Void
| Sum of typ * typ
[@@deriving sexp_of, compare, equal]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This spacing looks a little funny?

| InL of typ * typ * exp
| InR of typ * typ * exp
| Case of exp * var * exp * var * exp
[@@deriving sexp_of, compare, equal]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This spacing looks a little funny?

| Prod of typ * typ
| Void
| Sum of typ * typ
[@@deriving sexp_of, compare, equal]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[@@deriving sexp_of, compare, equal]
[@@deriving sexp_of, compare, equal]

| InL of typ * typ * exp
| InR of typ * typ * exp
| Case of exp * var * exp * var * exp
[@@deriving sexp_of, compare, equal]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[@@deriving sexp_of, compare, equal]
[@@deriving sexp_of, compare, equal]

@bechang bechang merged commit 311f824 into csci5535:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants