[WIP] Enable 'revad' StatefulSet for stateful workloads (e.g. Storage Provider backends, etc) #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuAlfageme
force-pushed
the
revad_statefulset
branch
from
f9cdb4c to
cecc3a9
Compare
This is specially useful when running into sharded scenarios as e.g. different storage providers to map users with different rules. Ref. cs3org/reva#1142 This commit contains a preliminary version, where the "real" uniqueness of each replica in the set (in terms of config) is yet to be implemented. First version will simply rely on the hostname as selector inside the 'configFiles' value for a user-provided toml file.
SamuAlfageme
force-pushed
the
revad_statefulset
branch
from
cecc3a9 to
cf3d141
Compare
... when the pod is deployed as part of an StatefulSet, so it can determine its identity on startup and pick the right config file from the '*-configfiles' mount.
SamuAlfageme
force-pushed
the
revad_statefulset
branch
from
cf3d141 to
0c32279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating as WIP for the moment as it needs careful regression testing for previous deployments. Version
1.2.4is temporary.This deployment is useful when multiple instances on Revad with unique, distinct features (like e.g. unique network identifiers and/or config files).
So far, we use
revad.configFilesas a dictionary holding the the unique config files, based on the pod'sHOSTNAME(no automated generation viainitContainerjust yet).Contributing a Chart / update to an existing Chart
helm linton the chart dir.Chart.yamlversion before merging, to release it as a new version.values.yaml. Add documentation in the appropiate README.