ci: use ubuntu-latest, fix Windows headers include order
#1353
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu 20.04 LTS runner will be removed on 2025-04-01. This change should have no effect as we use an Alpine container to perform the build itself.
elopez
force-pushed
the
fix-ci-ubuntu
branch
16 times, most recently
from
80fba80 to
e951e79
Compare
We need the system headers in the lookup path to find dependencies such as gmp. By re-including the system headers with `-I` or `extra-include-dirs`, they are used before the GHC-bundled headers, causing issues. Use `-idirafter` instead so they are used only as a last resort.
elopez
changed the title
ubuntu-latestubuntu-latest, fix Windows header include order
elopez
changed the title
ubuntu-latest, fix Windows header include orderubuntu-latest, fix Windows headers include order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 20.04 LTS runner will be removed on 2025-04-01. This change should have no effect as we use an Alpine container to perform the build itself.
This also fixes a build failure on Windows due to the heather paths being in an incorrect order.