feat: Add --autocommit flag to support database proxies#165
Open
jwee0330 wants to merge 1 commit into
Open
Conversation
Some database proxies (e.g. QueryPie, PgBouncer in transaction mode) block explicit transaction control statements (BEGIN/COMMIT/ROLLBACK). This makes it impossible to connect via postgres-mcp since psycopg's connection pool implicitly wraps queries in transactions. The --autocommit flag enables psycopg's autocommit mode on the connection pool, so each statement executes independently without implicit BEGIN. Can also be set via DATABASE_AUTOCOMMIT env var. Changes: - Add --autocommit CLI flag and DATABASE_AUTOCOMMIT env var to server.py - Add autocommit parameter to DbConnPool.pool_connect() - Skip BEGIN/COMMIT/ROLLBACK in SqlDriver._execute_with_connection() when connection is in autocommit mode - Add unit tests for autocommit behavior - Update README with configuration example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some database proxies (e.g. QueryPie, PgBouncer in transaction mode) block explicit transaction control statements (BEGIN/COMMIT/ROLLBACK). This makes it impossible to connect via postgres-mcp since psycopg's connection pool implicitly wraps queries in transactions.
The --autocommit flag enables psycopg's autocommit mode on the connection pool, so each statement executes independently without implicit BEGIN. Can also be set via DATABASE_AUTOCOMMIT env var.
Changes: