-
Notifications
You must be signed in to change notification settings - Fork 48
feat(ibc): support ibc-go v10 #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
So for now, we are still wired to v1 ? Do we still need to add v2 support? |
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #609 +/- ##
===========================================
- Coverage 46.13% 46.09% -0.05%
===========================================
Files 181 181
Lines 18217 18185 -32
===========================================
- Hits 8405 8382 -23
+ Misses 9087 9078 -9
Partials 725 725
🚀 New features to boost your workflow:
|
Do we have projects using Ethermint directly? If we want to add v2 support, I think we only need to wire it in the Cronos chain project (in app.go) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
A dependency PR of crypto-org-chain/cronos#1804