Skip to content

feat(ibc): support ibc-go v10 #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

JayT106
Copy link

@JayT106 JayT106 commented Jun 12, 2025

A dependency PR of crypto-org-chain/cronos#1804

@thomas-nguy
Copy link
Collaborator

So for now, we are still wired to v1 ?

Do we still need to add v2 support?
https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/13-v8_1-to-v10.md

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.09%. Comparing base (ee43f56) to head (bf3a81c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #609      +/-   ##
===========================================
- Coverage    46.13%   46.09%   -0.05%     
===========================================
  Files          181      181              
  Lines        18217    18185      -32     
===========================================
- Hits          8405     8382      -23     
+ Misses        9087     9078       -9     
  Partials       725      725              
Files with missing lines Coverage Δ
app/ante/eip712.go 59.42% <ø> (ø)
app/ante/handler_options.go 55.93% <ø> (ø)
app/app.go 78.05% <100.00%> (+0.26%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JayT106 JayT106 changed the title Problem: ibc-go v10 is not used feat(ibc): ibc-go v10 is not used Jun 19, 2025
@JayT106 JayT106 changed the title feat(ibc): ibc-go v10 is not used feat(ibc): support ibc-go v10 Jun 19, 2025
@JayT106
Copy link
Author

JayT106 commented Jun 19, 2025

So for now, we are still wired to v1 ?

Do we still need to add v2 support? https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/13-v8_1-to-v10.md

Do we have projects using Ethermint directly? If we want to add v2 support, I think we only need to wire it in the Cronos chain project (in app.go)

@JayT106 JayT106 self-assigned this Jun 19, 2025
@JayT106 JayT106 requested review from calvinaco, thomas-nguy and a team June 19, 2025 15:17
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants