Skip to content

Problem: go-ethereum v1.14.x change is not included #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

mmsqe
Copy link

@mmsqe mmsqe commented Mar 27, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 43.75000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 46.11%. Comparing base (f2ae8e8) to head (5a5b77b).

Files with missing lines Patch % Lines
x/evm/keeper/grpc_query.go 33.33% 8 Missing and 2 partials ⚠️
x/evm/statedb/statedb.go 50.00% 8 Missing ⚠️
rpc/types/utils.go 0.00% 5 Missing ⚠️
rpc/backend/sign_tx.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #438      +/-   ##
===========================================
- Coverage    46.13%   46.11%   -0.03%     
===========================================
  Files          181      181              
  Lines        18186    18202      +16     
===========================================
+ Hits          8390     8393       +3     
- Misses        9076     9086      +10     
- Partials       720      723       +3     
Files with missing lines Coverage Δ
app/ante/handler_options.go 55.93% <100.00%> (ø)
rpc/namespaces/ethereum/debug/api.go 0.00% <ø> (ø)
x/evm/keeper/state_transition.go 69.78% <100.00%> (-0.11%) ⬇️
x/evm/keeper/statedb.go 84.92% <100.00%> (ø)
x/evm/statedb/journal.go 95.50% <100.00%> (ø)
x/evm/statedb/state_object.go 98.33% <100.00%> (ø)
rpc/backend/sign_tx.go 57.94% <33.33%> (-1.86%) ⬇️
rpc/types/utils.go 0.00% <0.00%> (ø)
x/evm/statedb/statedb.go 76.22% <50.00%> (-1.61%) ⬇️
x/evm/keeper/grpc_query.go 76.14% <33.33%> (-1.25%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmsqe mmsqe changed the title Problem: go-ethereum v1.12.x change is not included Problem: go-ethereum v1.14.x change is not included Sep 25, 2024
Copy link

socket-security bot commented Sep 26, 2024

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
golang/github.com/mmsqe/[email protected] environment, eval, filesystem, network, shell, unsafe 0 38.9 MB
pypi/[email protected] network 0 113 kB bdraco
pypi/[email protected] None 0 120 kB bdraco
pypi/[email protected]3.11.16 Transitive: environment, eval, filesystem, network, shell, unsafe +863 3.76 GB
pypi/[email protected]1.3.2 filesystem 0 63.2 kB Andrew.Svetlov, mj
pypi/[email protected]5.0.1 Transitive: environment, eval, filesystem, network, shell, unsafe +735 3.28 GB Andrew.Svetlov, webknjaz
pypi/[email protected]24.2.0 Transitive: environment, eval, filesystem, network, shell, unsafe +727 3.28 GB hynek
pypi/[email protected]25.3.0 None 0 0 B
pypi/[email protected]3.3.0 None 0 1.19 MB ilanschnell
pypi/[email protected]24.10.0 environment, eval, filesystem, network, shell, unsafe +715 3.28 GB JelleZijlstra, ambv, cooperlees, ...2 more
pypi/[email protected]24.1.3 None 0 1.08 MB hynek, tinchester
pypi/[email protected]2024.12.14 None 0 309 kB Lukasa
pypi/[email protected]3.4.1 Transitive: network, shell, unsafe +715 3.28 GB Ousret
pypi/[email protected]8.1.8 Transitive: environment, eval, filesystem, network, shell, unsafe +723 3.28 GB
pypi/[email protected]1.0.1 Transitive: network +715 3.29 GB eriknw, hendrikmakait, jrbourbeau, ...1 more
pypi/[email protected]7.1.0 environment, filesystem, network, shell Transitive: eval, unsafe +729 3.32 GB aiordache, ccrone, dev-tooling-team, ...4 more
pypi/[email protected]0.16 None 0 108 kB krassowski
pypi/[email protected]5.2.0 Transitive: environment, eval, filesystem, network, shell, unsafe +735 3.28 GB carver, fselmo, kclowes, ...2 more
pypi/[email protected]0.8.1 environment, filesystem Transitive: eval, network, shell, unsafe +739 3.28 GB carver, kclowes, pacrob, ...1 more
pypi/[email protected]0.6.1 None +51 120 kB carver, kclowes, pacrob, ...1 more
pypi/[email protected]2.2.0 Transitive: environment, eval, filesystem, network, shell, unsafe +735 3.28 GB carver, fselmo, kclowes, ...2 more
pypi/[email protected]5.2.0 Transitive: environment, eval, filesystem, network, shell, unsafe +735 3.28 GB carver, cburgdorf, fselmo, ...5 more
pypi/[email protected]5.2.0 Transitive: environment, eval, filesystem, network, shell, unsafe +719 3.28 GB carver, cburgdorf, fselmo, ...5 more
pypi/[email protected]1.2.2 environment, eval, shell 0 131 kB
pypi/[email protected]0.7.0 None 0 381 kB dbieber
pypi/[email protected]1.5.0 Transitive: environment, eval, filesystem, network, shell, unsafe +743 3.28 GB Andrew.Svetlov, mj, webknjaz
pypi/[email protected]1.3.0 Transitive: environment, eval, filesystem, network, shell, unsafe +735 3.28 GB carver, fselmo, kclowes, ...2 more
pypi/[email protected]3.10 Transitive: environment, eval, filesystem, network, shell, unsafe +715 3.28 GB kjd
pypi/[email protected]2.1.0 None 0 15.9 kB hpk, ronny
pypi/[email protected]6.0.1 Transitive: environment, eval, filesystem, network, shell, unsafe +844 3.76 GB
pypi/[email protected]0.41.4 None 0 105 kB pappasam
pypi/[email protected]0.19.2 None 0 0 B
pypi/[email protected]2024.10.1 environment, filesystem Transitive: eval, network, shell, unsafe +719 3.28 GB
pypi/[email protected]4.23.0 Transitive: environment, eval, filesystem, network, shell, unsafe +721 3.29 GB
pypi/[email protected]6.2.0 Transitive: environment, eval, filesystem, network, shell, unsafe +723 3.28 GB Andrew.Svetlov, webknjaz
pypi/[email protected]24.2 Transitive: network, unsafe +715 3.28 GB brettcannon, dstufft, pf_moore, ...1 more
pypi/[email protected]0.10.0 None 0 190 kB erikrose, lonnen, lucaswiman
pypi/[email protected]4.3.7 Transitive: environment, eval, filesystem, network, shell, unsafe +715 3.28 GB Julian, Ofekmeister, ronny
pypi/[email protected]1.5.0 environment, filesystem, network, shell Transitive: eval, unsafe +719 3.28 GB The_Compiler, flub, goodboy, ...3 more
pypi/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +723 3.28 GB bdraco
pypi/[email protected]4.25.6 None 0 2.4 MB protobuf-packages
pypi/[email protected]2.13.0 None 0 161 kB IanLee1521, asottile
pypi/[email protected]3.22.0 Transitive: environment, eval, filesystem, network, shell, unsafe +715 3.28 GB
pypi/[email protected]2.33.0 None 0 7.42 MB dmontagu, samuelcolvin
pypi/[email protected]2.11.1 None 0 0 B
pypi/[email protected]3.3.2 None 0 0 B
pypi/[email protected]16.0.0 eval, filesystem 0 290 kB mlodewijck
pypi/pywin32@306310 None 0 24.5 MB glyph, mhammond, pf_moore
pypi/[email protected]1.4.1 filesystem 0 59.4 kB tanbro
pypi/[email protected]0.35.1 environment, filesystem Transitive: eval, network, shell, unsafe +719 3.28 GB
pypi/[email protected]0.36.2 None 0 360 kB
pypi/[email protected]2024.11.6 None 0 3.55 MB mrabarnett
pypi/[email protected]2.32.3 None 0 477 kB Lukasa, graffatcolmingov, nateprewitt
pypi/[email protected]4.1.0 Transitive: environment, eval, filesystem, network, shell, unsafe +735 3.28 GB carver, cburgdorf, kclowes, ...3 more
pypi/[email protected]0.22.3 Transitive: eval, network, shell +719 3.28 GB Julian
pypi/[email protected]0.24.0 None 0 1.92 MB Julian
pypi/[email protected]78.1.0 Transitive: environment, eval, filesystem, network, shell, unsafe +757 3.29 GB
pypi/[email protected]1.17.0 environment, filesystem 0 134 kB gutworth
pypi/[email protected]2.5.0 Transitive: environment, eval, filesystem, network, shell, unsafe +715 3.28 GB hugovk
pypi/[email protected]3.0.1 None 0 46.4 kB hugovk
pypi/[email protected]2.2.1 None 0 932 kB encukou, hauntsaninja, hukkin
pypi/[email protected]0.13.2 Transitive: environment, eval, filesystem, network, shell, unsafe +769 3.29 GB neersighted
pypi/[email protected]1.0.0 None 0 0 B
pypi/[email protected]4.12.2 environment, eval, filesystem, shell, unsafe 0 422 kB JelleZijlstra, guido, hauntsaninja, ...3 more
pypi/[email protected]4.13.1 None 0 539 kB JelleZijlstra, guido, hauntsaninja, ...3 more
pypi/[email protected]2.3.0 environment, eval, filesystem, network, shell, unsafe +718 3.28 GB SethMichaelLarson, shazow
pypi/[email protected]1.18.3 Transitive: environment, eval, filesystem, network, shell, unsafe +723 3.28 GB

🚮 Removed packages: golang/github.com/crypto-org-chain/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected]

View full report↗︎

mmsqe added 2 commits April 8, 2025 12:47
skip destruct
@@ -733,11 +738,11 @@
}
sended_hash_set = send_txs(w3, txs)
for txhash in sended_hash_set:
res = w3.eth.wait_for_transaction_receipt(txhash, timeout=10)
res = w3.eth.wait_for_transaction_receipt(txhash, timeout=20)

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning test

This assignment to 'res' is unnecessary as it is
redefined
before this value is used.
@thomas-nguy
Copy link
Collaborator

Almost completed.

Need go-ethereum fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants