-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: No record for ADR-009 permissioned addresses in Cronos #801
Problem: No record for ADR-009 permissioned addresses in Cronos #801
Conversation
fc3edf3
to
f165cae
Compare
4b0c4bf
to
d97057e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we could monitor those metrics on-chain and ask for execution of specific message automatically given the x/group
module.
the option 1 seems simple and flexible because we could do most of the monitoring work off-chain and only add the permissions map to the cronos store, while we need to specify the policy if we choose option 2.
I havent found anything related to "restrict message to a certain group" in x/module. Maybe in x/authz? but it seems more related to module's authorization. |
I have updated the ADR with final decision. Let me know if it is okay to merge |
Signed-off-by: Thomas Nguy <[email protected]>
Co-authored-by: adu-crypto <[email protected]> Signed-off-by: Thomas Nguy <[email protected]>
5223921
to
987d4ef
Compare
Co-authored-by: Tomas Tauber <[email protected]> Signed-off-by: Thomas Nguy <[email protected]>
Co-authored-by: Tomas Tauber <[email protected]> Signed-off-by: Thomas Nguy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #801 +/- ##
==========================================
+ Coverage 33.89% 34.26% +0.36%
==========================================
Files 30 30
Lines 1599 1582 -17
==========================================
Hits 542 542
+ Misses 1000 983 -17
Partials 57 57
|
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)