fix(command-palette): use data-checked for theme selection tick instead of manual icon#827
Open
aihnatiuk wants to merge 1 commit into
Open
fix(command-palette): use data-checked for theme selection tick instead of manual icon#827aihnatiuk wants to merge 1 commit into
aihnatiuk wants to merge 1 commit into
Conversation
…ad of manual icon
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe active-theme indicator in the command palette's theme list is changed from conditionally rendering a ChangesTheme Selection Indicator
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix tick icon positioning for the selected theme in the Command Palette.
Why
Theme picker in the Command Palette displays tick for the selected theme in the wrong position. This is caused by a duplicate
HugeiconsIconcomponent that is passed as a child to theCommandItemwhich has its own tick icon that has 0 opacity in this case. The change is to reuse existing functionality of theCommandItemand to avoid passing extra icon child.Testing
pnpm exec tsc --noEmitcleansrc-tauri/)cargo test --lockedandcargo clippy --all-targets --locked -- -D warningsclean#[tauri::command]signature) called out below so the FE caller can be updated in locksteppnpm tauri devScreenshots / GIFs
Before:


After:
Summary by CodeRabbit