Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resolving of notification content from exception message or message code #196

Conversation

agrancaric
Copy link
Collaborator

@agrancaric agrancaric commented Jan 22, 2024

Basic information

  • nrich version:
    2.1.1
  • Module:
    nrich-notification, nrich-webmvc

Additional information

Description

Summary

Add support for resolving of notification content from message or message code for exceptions

Details

Add support for resolving of notification content from message or message code for exceptions, move handling of exception arguments to NotificationResolver service

Related issue

Types of changes

  • Breaking change (fix, enhancement or feature that would cause existing functionality to change in backward-incompatible way)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric requested a review from jzrilic January 22, 2024 09:10
@agrancaric agrancaric self-assigned this Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.84%. Comparing base (dcc3608) to head (e690ce7).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #196   +/-   ##
=========================================
  Coverage     96.83%   96.84%           
- Complexity     1270     1272    +2     
=========================================
  Files           183      183           
  Lines          2908     2915    +7     
  Branches        252      254    +2     
=========================================
+ Hits           2816     2823    +7     
  Misses           38       38           
  Partials         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jzrilic jzrilic changed the title Add support for resolving of notification content from message or mes… Support resolving of notification content from exception message or message code Mar 1, 2024
@agrancaric agrancaric force-pushed the feature_addSupportForResolvingNotificationContentFromMessageOrMessageCode branch from 9a30331 to 8bd1411 Compare March 1, 2024 13:58
@agrancaric agrancaric requested a review from jzrilic March 1, 2024 13:58
@agrancaric agrancaric force-pushed the feature_addSupportForResolvingNotificationContentFromMessageOrMessageCode branch from 8bd1411 to b92dc87 Compare March 1, 2024 14:03
@agrancaric agrancaric force-pushed the feature_addSupportForResolvingNotificationContentFromMessageOrMessageCode branch from b92dc87 to e690ce7 Compare March 7, 2024 13:08
@jzrilic jzrilic merged commit 2ffe052 into master Mar 7, 2024
8 checks passed
@jzrilic jzrilic deleted the feature_addSupportForResolvingNotificationContentFromMessageOrMessageCode branch March 7, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants