Skip to content

syslog log_media: only add log hook once - #4819

Merged
blotus merged 3 commits into
masterfrom
blotus/syslog-log-lines-duplicated-after-sighup
Nov 13, 2026
Merged

blotus merged 3 commits into
masterfrom
blotus/syslog-log-lines-duplicated-after-sighup

Conversation

@blotus

@blotus blotus commented Nov 10, 2026

Copy link
Copy Markdown
Member

Fixes #4817.

Also remove the hook on a reload that moves away fromsyslog.

@github-actions

Copy link
Copy Markdown

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions

Copy link
Copy Markdown

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.91%. Comparing base (8e525b5) to head (db97d66).

Files with missing lines Patch % Lines
pkg/logging/syslog.go 93.33% 1 Missing ⚠️
pkg/logging/syslog_windows.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4819      +/-   ##
==========================================
- Coverage   72.24%   71.91%   -0.33%     
==========================================
  Files         528      546      +18     
  Lines       36593    37264     +671     
==========================================
+ Hits        26437    26800     +363     
- Misses      10155    10463     +308     
  Partials        1        1              
Flag Coverage Δ
bats 45.34% <73.07%> (+0.02%) ⬆️
unit-linux 49.95% <84.61%> (+0.11%) ⬆️
unit-windows 37.90% <16.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blotus blotus added this to the 1.8.3 milestone Nov 12, 2026
@blotus

blotus commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

/kind fix

@buixor
buixor requested a review from sabban November 13, 2026 13:01

@sabban sabban left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk if it's intended, but the PR managed to register the logger once; if the configuration changes on reload, it may be loaded twice. This is a corner case and not a regression, so I'm fine with it.

@blotus
blotus merged commit 5195ec6 into master Nov 13, 2026
17 checks passed
@blotus
blotus deleted the blotus/syslog-log-lines-duplicated-after-sighup branch November 13, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

syslog log lines duplicated after SIGHUP

2 participants