Repository navigation
syslog log_media: only add log hook once - #4819
Conversation
|
@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@blotus: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4819 +/- ##
==========================================
- Coverage 72.24% 71.91% -0.33%
==========================================
Files 528 546 +18
Lines 36593 37264 +671
==========================================
+ Hits 26437 26800 +363
- Misses 10155 10463 +308
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/kind fix |
sabban
left a comment
There was a problem hiding this comment.
Idk if it's intended, but the PR managed to register the logger once; if the configuration changes on reload, it may be loaded twice. This is a corner case and not a regression, so I'm fine with it.
Fixes #4817.
Also remove the hook on a reload that moves away from
syslog.