Repository navigation
packaging: detect api.server.enable: false in postinst - #4818
Conversation
cscli config show --key prints *bool values as "&false", so the "= false" check added in #3802 never matched. On agent-only hosts with a listen_uri set and the port held by something else, the service was not started after install/upgrade. -o json prints a plain "false". Fixes #4651 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@sabban: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@sabban: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4818 +/- ##
==========================================
+ Coverage 64.79% 71.84% +7.04%
==========================================
Files 545 545
Lines 37167 37167
==========================================
+ Hits 24082 26702 +2620
+ Misses 13074 10464 -2610
+ Partials 11 1 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/area agent |
Fixes #4651 by using -o json to avoid cscli output as &false.
What and why
Fixes #4651
How it was tested
Checklist
cscli -o json|rawoutput.AI assistance used: