Repository navigation
apiserver: log unenrolled-console message at warning level - #4811
bharathvemula wants to merge 1 commit into
Conversation
Console enrollment is optional, but the message was logged at error level whenever CAPI was enabled on a machine that is not enrolled. Demote it to warning, matching the parallel message in initAPIC, and cover both the enrolled and unenrolled paths with a regression test.
|
@bharathvemula: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@bharathvemula: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
/kind fix |
|
So let me get this straight:
I guess you did not even have the basic decency of looking at the change ? We all have access to LLMs, please please please don't bother opening PRs or issues if you are not even going to have the slightest look at them, I can also ask Claude to slop its way through the repo. |
Fixes #4809
With CAPI enabled on a machine that is not enrolled in the console, startup logged "Machine is not enrolled in the console, can't synchronize with the console" at error level. Enrollment is optional, so a deliberate non-enrollment looked like a failure. The message is now logged at warning level, matching the parallel message in initAPIC ("can't synchronize decisions", already a warning).
Tested: new TestNewServerConsoleEnrollmentLogLevel (fails before, passes after — unenrolled case logs the message once at warning and never at error; enrolled case logs nothing about enrollment);
go test ./pkg/apiserver/...passes;go vetclean;golangci-lint run ./pkg/apiserver/...(v2.13.0) 0 issues. Fullmake testnot run.Note: #4809 still carries needs/triage.
Testing above was run by an AI agent; no human has independently verified it yet.
Disclosure: this PR was prepared with AI assistance.