Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vars): $randomActiveViewer Enhancements (#2805) #3027

Open
wants to merge 1 commit into
base: v5
Choose a base branch
from
Open

feat(vars): $randomActiveViewer Enhancements (#2805) #3027

wants to merge 1 commit into from
+86 −32

Conversation

phroggster
Copy link
Collaborator

@phroggster phroggster commented Feb 28, 2025 •
edited
Loading

Description of the Change

  • Accept either a single custom role name or an array of multiple custom role names for inclusion filtering..
  • Accept either a single user name or an array of multiple user names for exclusion filtering.
  • Add a parameter to exclude a single custom role name or an array of custom role names.
  • Add a parameter to return either or both the username and/or id.
    • displayName is unavailable here though, sadly.
    • Good thing there's a variable available for that. 😁
  • Uses $arrayFrom[..., ...] for one readable example of array parameters.
    • Which also shows that $streamer and $bot should probably always be added to the ignored users filter.
  • Squashed an historic bug in activeUserHandler.getAllActiveUsers that was returning user ids as number instead of string.

Applicable Issues

#2805

Testing

Tested quite a bit for all filtering scenarios.

Screenshots

vars menu expanded v2

@phroggster phroggster requested a review from ebiggz as a code owner February 28, 2025 01:04
@phroggster phroggster marked this pull request as draft February 28, 2025 11:19
@phroggster
feat(vars): $randomActiveViewer Enhancements (crowbartools#2805)
105ee77 
- Accept multiple role names for role inclusion filtering.
- Accept multiple user names for user exclusion filtering.
- Add a param to exclude a role or multiple roles.
- Add a param to return either or both the username and/or id.
  - displayName is unavailable here though, sadly.
  - Good thing there's a variable for that.
- bugfix: activeUserHandler.getAllActiveUsers was returning numeric ids
  instead of string ids as typed.
@phroggster phroggster marked this pull request as ready for review March 1, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebiggz ebiggz Awaiting requested review from ebiggz ebiggz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phroggster