-
Notifications
You must be signed in to change notification settings - Fork 149
Add function-pythonic information and examples #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jbw976
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @iciclespider, thank you for adding function-pythonic to these guides! 😲
Looks like the preview site deployment and PR checks are failing with this build error:
8:23:47 PM: Error: error building site: process: readAndProcessContent: "/opt/build/repo/content/master/guides/connection-details-composition.md:286:10": unclosed shortcode
Hopefully you'll be able to iterate locally to build and test the site rendering locally using hugo server, see more details in the docs contributing getting started page: https://docs.crossplane.io/contribute/contribute/
9649a50 to
d002909
Compare
|
@jbw976 All checks have passed This should now be ready for review. |
jbw976
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @iciclespider, thank you for taking the time to add pythonic to these 2 guides!! I took a pass through both of them and they worked successfully for me 💪
Just a few typos/wording changes to consider here and then we should be able to merge this in! 🙇♂️
Signed-off-by: Patrick J. McNerthney <[email protected]>
Signed-off-by: Patrick J. McNerthney <[email protected]>
8cac513 to
207125c
Compare
|
@jbw976 Back at you! |
jbw976
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @iciclespider, thanks for following up to see this one through! 💪
|
@jbw976 Thanks for the prompt reviews! Now, what is the process to get those updates from the |
|
great question 😂 this repo doesn't use git branches for backports, so you basically manually copy the content in between dirs under brief mention (but not very thorough) from docs contributing guide: https://docs.crossplane.io/contribute/contribute/#contribute-to-a-specific-version |

This PR adds function-pythonic implementations to both the Get Start App Composition and to the Connection Details Composition.