Skip to content

Conversation

@iciclespider
Copy link

This PR adds function-pythonic implementations to both the Get Start App Composition and to the Connection Details Composition.

@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 207125c
🔍 Latest deploy log https://app.netlify.com/projects/crossplane/deploys/696ab78b7df0140008adda0d
😎 Deploy Preview https://deploy-preview-1039--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 2 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @iciclespider, thank you for adding function-pythonic to these guides! 😲

Looks like the preview site deployment and PR checks are failing with this build error:

8:23:47 PM: Error: error building site: process: readAndProcessContent: "/opt/build/repo/content/master/guides/connection-details-composition.md:286:10": unclosed shortcode

Hopefully you'll be able to iterate locally to build and test the site rendering locally using hugo server, see more details in the docs contributing getting started page: https://docs.crossplane.io/contribute/contribute/

@iciclespider iciclespider force-pushed the pythonic branch 4 times, most recently from 9649a50 to d002909 Compare January 15, 2026 07:30
@iciclespider
Copy link
Author

@jbw976 All checks have passed This should now be ready for review.

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @iciclespider, thank you for taking the time to add pythonic to these 2 guides!! I took a pass through both of them and they worked successfully for me 💪

Just a few typos/wording changes to consider here and then we should be able to merge this in! 🙇‍♂️

Patrick J. McNerthney added 2 commits January 16, 2026 12:11
Signed-off-by: Patrick J. McNerthney <[email protected]>
@iciclespider
Copy link
Author

@jbw976 Back at you!

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @iciclespider, thanks for following up to see this one through! 💪

@jbw976 jbw976 merged commit bb768f6 into crossplane:master Jan 17, 2026
7 checks passed
@iciclespider
Copy link
Author

@jbw976 Thanks for the prompt reviews! Now, what is the process to get those updates from the master docs to the v2.1 and v2.0 docs?

@jbw976
Copy link
Member

jbw976 commented Jan 17, 2026

great question 😂

this repo doesn't use git branches for backports, so you basically manually copy the content in between dirs under /content/. Feel free to open another PR that copies what you've done to v2.1 and v2.0, similar to what I did in:

brief mention (but not very thorough) from docs contributing guide: https://docs.crossplane.io/contribute/contribute/#contribute-to-a-specific-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants