Fix deletion of an Object not prompting deletion of resources dependent on the main object#437
Open
alanrichman wants to merge 1 commit intocrossplane-contrib:mainfrom
Open
Fix deletion of an Object not prompting deletion of resources dependent on the main object#437alanrichman wants to merge 1 commit intocrossplane-contrib:mainfrom
alanrichman wants to merge 1 commit intocrossplane-contrib:mainfrom
Conversation
…dent resources are deleted when object is deleted Signed-off-by: Alan Richman <alanrichman@duck.com>
alanrichman
requested review from
erhancagirici,
lsviben,
morningspace,
phisco,
sergenyalcin,
turkenf,
turkenh and
ulucinar
as code owners
Collaborator
|
This would mean everything gets deleted with foreground deletion, which would be a substantial behavior change. What if we made it configurable through the Object spec, defaulting to Background to preserve the current behavior? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #342
When an
Objectresource is deleted, dependent resources (particularly Pods owned by Jobs) are not being properly cleaned up, resulting in orphaned Pods that remain in the cluster for a long time. In my experience it is about a week.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I followed the same procedure from the original issue with the current latest version of the provider (v1.2.1) and with the modified version from my fork. I validated that before the change Object deletion removed the Job but not its Pods, after the change Object deletion removed the Job and Pods.