Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

(fix)(ec2-asg): fix autoscalinggroup by ignoring availability_zones which conflicts with `vpc_zone_identifier' field#238

Open
arturo-skydio wants to merge 1 commit intocrossplane-contrib:mainfrom
arturo-skydio:fix/ec2-asg
Open

(fix)(ec2-asg): fix autoscalinggroup by ignoring availability_zones which conflicts with `vpc_zone_identifier' field#238
arturo-skydio wants to merge 1 commit intocrossplane-contrib:mainfrom
arturo-skydio:fix/ec2-asg

Conversation

@arturo-skydio
Copy link

Description of your changes

  • This fixes an issue where when you try to create an autoscalinggroup and specify vpcZoneIdentifier you get the following observer issue and are not able to update resource:
observe failed: cannot run refresh: refresh failed: Conflicting configuration arguments: "availability_zones": conflicts with vpc_zone_identifier: File name: main.tf.json
Conflicting configuration arguments: "vpc_zone_identifier": conflicts with availability_zones: File name: main.tf.json

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Run controller package revision from this codebase and tested the same resource, this time I no longer get the observe failed error

Signed-off-by: Arturo Contreras <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant