feat: customizable ttl

[fernandezcuesta]

Description of your changes

Add the ability to set a custom TTL for the function response.

It allows 3 ways to set it up besides the current (default), from lower to higher precedence:

• default (current behaviour)
• as a cli argument (deploymentruntimeconfig)
• as a function input
• as an annotation in the XR

Fixes #424

I have:

• Read and followed Crossplane's contribution process.
• Added or updated unit tests for my change.

[chlunde]

go1.24.3 was a security release so if updating to 1.24, it should be 1.24.3 (or .4 in a couple of days)

[fernandezcuesta]

Is there a chance to get this PR reviewed, or in other words, is there anything utterly bad with it/some reason not to approve it? I can invest time resolving the conflicts but want to know first if it makes sense as is. 🙇

[bobh66]

Hi @fernandezcuesta - sorry for the delay. It looks like there are merge conflicts that need to be resolved.

Also I think it would be better to limit this PR to just the TTL changes and leave the other changes to separate PRs.

[fernandezcuesta]

Sure I'll split them into two then (basically remove all bump ups in actions and golangcilint)

[fernandezcuesta]

@bobh66 done

[fernandezcuesta]

Closing as this PR doesn't look to be of interest.

[Ata-NovacekJan]

Hi @fernandezcuesta , I'd like to ask you - how did you work around this problem in the end? We're facing performance issues with the TTL being its root cause - a huge spike in Crossplane operations after switching to realtime compositions - and came to very similar solution as you did here, just without the contribution due to ... well, inactivity of maintainers, that's how your contribution ended. :(

[fernandezcuesta]

Hi @Ata-NovacekJan once we enabled real-time compositions I guess this doesn't apply that much. My understanding is that a function that doesn't set a TTL is not affecting the pipeline overall in the sense that:

• The reconciler triggers as defined by the final TTL, which would be the minimum non-zero (set) TTL of the functions in the pipeline.
• If no function sets a TTL, the behavior depends on mode, RT composition doesn't requeue XR reconciliation (just watches changes), classic mode falls back to the poll interval (1min).

So my understanding is that setting a TTL would force the composition to reconcile periodically. In our case, the problem was a continous drift of arrays being sorted by crossplane-runtime. Nothing that TTL would help with.

[bobh66]

@fernandezcuesta would you be interested in bringing this PR up to date? I think it would be useful to have this feature. Thanks!

[fernandezcuesta]

@bobh66 sure, let me work on it later today

[bobh66]

LGTM - thanks!