Allow Cargo.toml as configuration source#842
Merged
bors[bot] merged 1 commit intocross-rs:mainfrom Jun 23, 2022
Merged
Conversation
Emilgardis
changed the title
Cargo.toml as configuration source (new)Cargo.toml as configuration source
Emilgardis
approved these changes
Jun 23, 2022
Member
Emilgardis
left a comment
Emilgardis
left a comment
There was a problem hiding this comment.
Awesome! Thanks :D
please fix the pr number in the changelog, maybe also rebase the commits.
Member
|
can you squash the commits also? |
Implement merging for configurations Make merge take owned values Unify field merging in config merging Add new merging code by @Alexhuszagh Improve CrossToml error handling Parse configs from strings in CrossToml merge test Fix PR number in changelog entry
Contributor
|
Build succeeded: |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a GitHub mishap in #754, this is a new PR containing the same commits (rebased by @Emilgardis). Just for reference, it still addresses #657.