Skip to content

Conversation

Dylan-DPC-zz
Copy link

The bors builds are failing probably because of the verbosity of the build. Removing this as per this comment

@Dylan-DPC-zz Dylan-DPC-zz requested review from jamesmunns and a team as code owners September 29, 2018 15:12
@Dylan-DPC-zz Dylan-DPC-zz added the meta issues/PRs related to the maintenance of the crate. label Sep 29, 2018
@Bobo1239
Copy link
Contributor

Just as a hint for those wondering what this does: https://github.com/rust-embedded/cross#qemu_strace-v019

@ryankurte
Copy link

bors r+

bors bot added a commit that referenced this pull request Sep 29, 2018
213: remove export to make CI process less verbose r=ryankurte a=Dylan-DPC

The bors builds are failing probably because of the verbosity of the build. Removing this as per [this comment](#206 (comment))

Co-authored-by: Dylan DPC <[email protected]>
@ryankurte
Copy link

Ah heck, that's not going to work without the other PR is it...

@Dylan-DPC I'm happy with a manual merge of this if you'd like, or for it to be combined with the big build issues PR for simplicity.

@bors
Copy link
Contributor

bors bot commented Sep 30, 2018

Build failed

@Dylan-DPC-zz
Copy link
Author

@ryankurte yah this won't work with bors because it will use the only travis config. Will merge it manually 👍

@Dylan-DPC-zz
Copy link
Author

Dylan-DPC-zz commented Sep 30, 2018

Update: we are blocked by #180 😞

Edit: Just realised, since this PR is just to make the build less verbose, I'm just going ahead and merging it since the failures are unrelated to this case.

@Dylan-DPC-zz
Copy link
Author

Dylan-DPC-zz commented Sep 30, 2018

Update: I need someone with permissions to disable bors temporarily so that we can merge this and then restore the old setting.

@ryankurte
Copy link

Huh, looks like cli merge is blocked too, and I don't think I can manage bors installs.

@Dylan-DPC it's still a build issue imo, how about just applying it over #206?

@Dylan-DPC-zz
Copy link
Author

@ryankurte I prefer to keep it as separate Prs because once this is fixed we can tackle the other build issues in #206.

Also if you disable bors temporarily we can merge this since bors is the only status check.

@Dylan-DPC-zz
Copy link
Author

@ryankurte yeah both of us aren't organisation owners so we can't. Have to wait for the one of the owners to do it.

@ryankurte
Copy link

I was under the impression we were about to merge and close 206 anyway?

cc. @japaric as the bors-whisperer.

@Dylan-DPC-zz
Copy link
Author

Yeah but I'd prefer separate Prs instead of overloading a single PR and also it gives the opportunity to test #206 with bors (even though it passed when we manually restarted travis).

@ryankurte ryankurte mentioned this pull request Oct 4, 2018
@Dylan-DPC-zz
Copy link
Author

closing this since #206 is merged

@Dylan-DPC-zz Dylan-DPC-zz deleted the meta/ci-process branch October 8, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta issues/PRs related to the maintenance of the crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants