-
Notifications
You must be signed in to change notification settings - Fork 410
remove export to make CI process less verbose #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just as a hint for those wondering what this does: https://github.com/rust-embedded/cross#qemu_strace-v019 |
bors r+ |
213: remove export to make CI process less verbose r=ryankurte a=Dylan-DPC The bors builds are failing probably because of the verbosity of the build. Removing this as per [this comment](#206 (comment)) Co-authored-by: Dylan DPC <[email protected]>
Ah heck, that's not going to work without the other PR is it... @Dylan-DPC I'm happy with a manual merge of this if you'd like, or for it to be combined with the big build issues PR for simplicity. |
Build failed |
@ryankurte yah this won't work with bors because it will use the only travis config. Will merge it manually 👍 |
Edit: Just realised, since this PR is just to make the build less verbose, I'm just going ahead and merging it since the failures are unrelated to this case. |
Update: I need someone with permissions to disable bors temporarily so that we can merge this and then restore the old setting. |
Huh, looks like cli merge is blocked too, and I don't think I can manage bors installs. @Dylan-DPC it's still a build issue imo, how about just applying it over #206? |
@ryankurte I prefer to keep it as separate Prs because once this is fixed we can tackle the other build issues in #206. Also if you disable bors temporarily we can merge this since bors is the only status check. |
@ryankurte yeah both of us aren't organisation owners so we can't. Have to wait for the one of the owners to do it. |
I was under the impression we were about to merge and close 206 anyway? cc. @japaric as the bors-whisperer. |
Yeah but I'd prefer separate Prs instead of overloading a single PR and also it gives the opportunity to test #206 with bors (even though it passed when we manually restarted travis). |
closing this since #206 is merged |
The bors builds are failing probably because of the verbosity of the build. Removing this as per this comment