Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PP processing (rebased) #469

Merged
merged 27 commits into from
Feb 2, 2025
Merged

Add PP processing (rebased) #469

merged 27 commits into from
Feb 2, 2025

Conversation

J08nY
Copy link
Member

@J08nY J08nY commented Feb 1, 2025

Rebased on main, nice history now.

@J08nY J08nY added enhancement New feature or request pp Related to Protection Profiles labels Feb 1, 2025
@J08nY J08nY linked an issue Feb 1, 2025 that may be closed by this pull request
@J08nY J08nY force-pushed the feat/pp-processing branch from da29f29 to 8031764 Compare February 1, 2025 21:58
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 79.83425% with 219 lines in your changes missing coverage. Please review.

Project coverage is 69.46%. Comparing base (7407773) to head (63f993b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/sec_certs/utils/label_studio_utils.py 0.00% 56 Missing ⚠️
src/sec_certs/sample/protection_profile.py 78.82% 43 Missing ⚠️
...rc/sec_certs/dataset/auxiliary_dataset_handling.py 84.27% 31 Missing ⚠️
src/sec_certs/utils/cc_html_parsing.py 36.67% 19 Missing ⚠️
src/sec_certs/dataset/protection_profile.py 92.35% 15 Missing ⚠️
src/sec_certs/dataset/dataset.py 62.17% 14 Missing ⚠️
src/sec_certs/heuristics/common.py 85.34% 11 Missing ⚠️
src/sec_certs/dataset/cc.py 82.61% 8 Missing ⚠️
src/sec_certs/heuristics/cc.py 90.81% 8 Missing ⚠️
src/sec_certs/cli.py 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   68.55%   69.46%   +0.92%     
==========================================
  Files          62       69       +7     
  Lines        7934     8346     +412     
==========================================
+ Hits         5438     5797     +359     
- Misses       2496     2549      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J08nY
Copy link
Member Author

J08nY commented Feb 2, 2025

@adamjanovsky I noticed that you changed the layout of the full CC dataset (namely the paths to the auxilliary datasets). It is now more consistent, though it requires changes on the site and during the transition period it will not be compatible.

I somehow deduced that this is the global structure for CC:

    Dataset
    =======

    ├── auxiliary_datasets
    │   ├── cpe_dataset.json
    │   ├── cve_dataset.json
    │   ├── cpe_match.json
    │   ├── cc_scheme.json
    │   ├── protection_profiles
    │   │   ├── reports
    │   │   │   ├── pdf
    │   │   │   └── txt
    │   │   ├── pps
    │   │   │   ├── pdf
    │   │   │   └── txt
    │   │   └── pp.json
    │   └── maintenances
    │       ├── certs
    │       │   ├── reports
    │       │   │   ├── pdf
    │       │   │   └── txt
    │       │   └── targets
    │       │       ├── pdf
    │       │       └── txt
    │       └── maintenance_updates.json
    ├── certs
    │   ├── reports
    │   │   ├── pdf
    │   │   └── txt
    │   ├── targets
    │   │   ├── pdf
    │   │   └── txt
    │   └── certificates
    │       ├── pdf
    │       └── txt
    └── dataset.json

This is it for FIPS:

    Dataset
    =======

    ├── auxiliary_datasets
    │   ├── cpe_dataset.json
    │   ├── cve_dataset.json
    │   ├── cpe_match.json
    │   └── algorithms.json         (only FIPS)
    ├── certs
    │   └── targets
    │       ├── pdf
    │       └── txt
    └── dataset.json

and for PP:

    Dataset
    =======

    ├── reports
    │   ├── pdf
    │   └── txt
    ├── pps
    │   ├── pdf
    │   └── txt
    └── pp.json

@J08nY J08nY merged commit 1329b41 into main Feb 2, 2025
4 checks passed
@J08nY J08nY deleted the feat/pp-processing branch February 2, 2025 15:54
@adamjanovsky
Copy link
Collaborator

Note: comments on design, future work and caveats are in the original PR: #466 (this is a duplicate PR with streamlined history).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pp Related to Protection Profiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New API: Allow for full-fledged processing of protection profiles
2 participants